Hi!
rtmpe_write() exploits knowledge about av_rc4_crypt() internals and
passes the same
pointer as src and dst. I assume this is intentional for performance
reasons, the only
way to silence the resulting warning is a cast afaict.
Please comment, Carl Eugen
From 397b209506beb6c5a2acbe19bba98393216f1d0c Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffm...@gmail.com>
Date: Mon, 16 Apr 2018 00:14:24 +0200
Subject: [PATCH] lavf/rtmpcrypt: Add a cast to silence an unavoidable
warning.
Silences the following warning:
libavformat/rtmpcrypt.c:304:36: warning: passing argument 2 of 'av_rc4_crypt' discards 'const' qualifier from pointer target type
---
libavformat/rtmpcrypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtmpcrypt.c b/libavformat/rtmpcrypt.c
index c41ae43..253b8ca 100644
--- a/libavformat/rtmpcrypt.c
+++ b/libavformat/rtmpcrypt.c
@@ -301,7 +301,7 @@ static int rtmpe_write(URLContext *h, const uint8_t *buf, int size)
if (rt->handshaked) {
/* encrypt data to send to the server */
- av_rc4_crypt(&rt->key_out, buf, buf, size, NULL, 1);
+ av_rc4_crypt(&rt->key_out, (uint8_t *)buf, buf, size, NULL, 1);
}
if ((ret = ffurl_write(rt->stream, buf, size)) < 0)
--
1.7.10.4
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
