On 26.04.2018 16:11, Derek Buitenhuis wrote:
On 4/26/2018 3:06 PM, Tobias Rapp wrote:
+        if (ost->top_field_first == 0) {
+            enc_ctx->field_order = AV_FIELD_BB;
+        } else if (ost->top_field_first == 1) {
+            enc_ctx->field_order = AV_FIELD_TT;
+        }

This doesn't look correct; ost->top_field_first is only
valid if ost->interlaced_frame is set. Wouldn't this
incorrectly set field_order on progressive streams,
which should be set to AV_FIELD_PROGRESSIVE?

"ost" is of type OutputStream here, which only has top_field_first with values auto=-1/bff=0/tff=1. AVFrame has the interlaced_frame/top_field_first pair you mentioned, while AVCodecContext has field_order.

Regards,
Tobias

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to