Hi, 2018-08-13 0:02 GMT+02:00 Vasile Toncu <vasile.to...@tremend.com>:
> Hello, > > I have updated patch 3 according to review, removed all code related to the > new flags (MERGE_TFF, MERGE_BFF) and threading functionality. > > Thanks, your patch looks fine to me now. There is just one thing, I forgot to mention last review: > {....} > - if (tinterlace->flags & (TINTERLACE_FLAG_VLPF | TINTERLACE_FLAG_CVLPF) > - && !(tinterlace->mode == MODE_INTERLEAVE_TOP > - || tinterlace->mode == MODE_INTERLEAVE_BOTTOM)) { > - av_log(ctx, AV_LOG_WARNING, "low_pass_filter flags ignored with > mode %d\n", > - tinterlace->mode); > > {....} > + if (tinterlace->flags & FLAG_VLPF || tinterlace->flags & FLAG_CVLPF) { > > - av_log(ctx, AV_LOG_VERBOSE, "mode:%d filter:%s h:%d -> h:%d\n", > tinterlace->mode, > - (tinterlace->flags & TINTERLACE_FLAG_CVLPF) ? "complex" : > - (tinterlace->flags & TINTERLACE_FLAG_VLPF) ? "linear" : "off", > - inlink->h, outlink->h); > Please keep the log messages. Nothing should change for the user. Regards, Thomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel