So, what do we do now? Honor the doxy and stop trying to manipulate
what's meant to be an user owned pointer/buffer, officially break the
API and declare it's meant to be allocated by the user but then
ownership is passed to the library during or after the avcodec_open2()
call, or just revert this commit and pretend nothing happened?

Documenting the API break that already happened seems like the least bad option right now. Firefox already merged code to work around the crash.

It already is freed in multiple places, so existing code probably already is compatible.

No solution to this is overly pretty unfortunately.
Specially as this goes along with likely leaking the extradata pointer, as unconditionally freeing it will most definitely cause crashes left and right.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

ffmpeg-devel mailing list

Reply via email to