On Sat, Sep 22, 2018 at 3:25 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Thu, Sep 20, 2018 at 10:39:37AM +0800, myp...@gmail.com wrote: > > On Wed, Sep 19, 2018 at 7:07 PM Michael Niedermayer > > <mich...@niedermayer.cc> wrote: > > > > > > On Tue, Sep 18, 2018 at 09:37:29PM +0800, Jun Zhao wrote: > > > > Fixes ticket #7441. > > > > > > > > Signed-off-by: Jun Zhao <mypopy...@gmail.com> > > > > --- > > > > libavfilter/vf_deshake.c | 12 +++++++----- > > > > 1 files changed, 7 insertions(+), 5 deletions(-) > > > > > > this doesnt look correct > > > > > > the blocks that will be used are not going out of array? so the contrast > > > calculated from them also should not > > > > > Do you mean the correct way is changing the pos calculated from: > > pos = (y - i) * stride + (x - j); to pos = (y + i) * stride + (x + j) ? > > Iam not the author of vf_deshake, but whatever aligns the checked blocks > correctly, should be the correct solution
Agree, so I submitted V2 patch for this issue, Thanks. > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Modern terrorism, a quick summary: Need oil, start war with country that > has oil, kill hundread thousand in war. Let country fall into chaos, > be surprised about raise of fundamantalists. Drop more bombs, kill more > people, be surprised about them taking revenge and drop even more bombs > and strip your own citizens of their rights and freedoms. to be continued > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel