Hi Marton, On Wed, 7 Nov 2018 10:29:31 +0100 (CET) Marton Balint <c...@passwd.hu> wrote:
> On Wed, 7 Nov 2018, Shlomi Fish wrote: > > > On Wed, 4 Jul 2018 23:10:46 +0300 > > Shlomi Fish <shlo...@shlomifish.org> wrote: > > > > Ping/bump! Can this patch be reviewed already? > > Does your patch has any measureable speed difference for some streams? It > seems like a very micro optimialization, because ff_metadata_conv bails > out early as well. > First of all note that I recall it being the case for several function calls in succession there. Secondly, I didn't measure it, but see what I wrote at: https://en.wikibooks.org/wiki/Optimizing_Code_for_Speed/Factor_Optimizations#Are_%22Small%22_Optimizations_Desirable? non-inline function calls can be quite slow. > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ http://www.shlomifish.org/humour/bits/Can-I-SCO-Now/ - βCan I SCO Now?β You name it β COBOL does not have it. β http://is.gd/ClKAz5 Please reply to list if it's a mailing list post - http://shlom.in/reply . _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel