On 02/12/2018 21:58, Carl Eugen Hoyos wrote: > 2018-12-02 22:35 GMT+01:00, Mark Thompson <s...@jkqxz.net>: >> On 02/12/2018 21:12, Carl Eugen Hoyos wrote: >>> 2018-12-02 20:46 GMT+01:00, Mark Thompson <s...@jkqxz.net>: >>>> On 02/12/2018 12:49, Carl Eugen Hoyos wrote: >>>>> 2018-11-23 1:48 GMT+01:00, Carl Eugen Hoyos <ceffm...@gmail.com>: >>>>>> 2018-11-22 23:47 GMT+01:00, Mark Thompson <s...@jkqxz.net>: >>>>>>> Standard sed does not support EREs. >>>>>> >>>>>> Please mention ticket #7310 in the commit message. >>>>> >>>>> Ping. >>>> >>>> I was waiting for: >>> >>> Sorry, thank you! >>> >>>>> The Darwin version script part was only tested by running it on the >>>>> version scripts and looking at the output, not actually building on that >>>>> platform - it would be helpful if someone could check that it actually >>>>> works. >>>> >>>> Can someone check this? >>> >>> Why is this needed? >>> What I mean is: Is there a Darwin platform with a too old sed where >>> your change would help? >> >> I have no idea - I know nothing about tools on Apple platforms. If all >> versions of sed you might be able to run on Darwin have a nonstandard >> extension supporting EREs via a -E option then it is indeed unnecessary, but >> given the nature of the patch I thought it would be sensible to eliminate >> all of the potentially-troublesome nonstandard use. On the other hand it is >> a change and could break things which currently work, so ensuring that it >> has been tested on the actual target platform seemed like a good idea. > > In the meantime, you could commit the tested part of the patch.
Sure; applied. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
