On 27/12/2018 11:06, Guo, Yejun wrote:
> +        AVFrameSideData *sd = av_frame_get_side_data(frame, 
> AV_FRAME_DATA_ROIS);
> +        if (sd != NULL) {

Nit: `if (sd)` is convention.

> +                    qoffsets = (float*)av_mallocz_array(mbx * mby, 
> sizeof(*qoffsets));
> +                    if (qoffsets == NULL)

Nit: `if (!qoffsets)` is convention.

Rest is OK, I think.

Whoever pushes the patch (or me, whatever) can fix the few style nits above.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to