Please ignore those commented lines which will be removed in the v2 patch, they were referred from previous reap_filters() code.
"if (HAVE_THREADS && !abr_pipeline)" looks better. Could you add more about "not work with thread emulation"? Thx. -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Thursday, January 10, 2019 4:51 AM To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] Improved the performance of 1 decode + N filter graphs and adaptive bitrate. 2019-01-09 21:50 GMT+01:00, Shaofei Wang <shaofei.w...@intel.com>: > + //if (ost->source_index >= 0) > + // *filtered_frame= > *input_streams[ost->source_index]->decoded_frame; //for me_threshold Is there a reason why this is commented? > @@ -2179,7 +2285,15 @@ static int ifilter_send_frame(InputFilter > *ifilter, AVFrame *frame) > } > } > > +#if HAVE_THREADS > + if (!abr_pipeline) { The following is less ugly: if (HAVE_THREADS && !abr_pipeline) Same below, you can define the new variables unconditionally. But why does your code not work with FFmpeg's thread emulation? Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
