2019-01-27 1:45 GMT+01:00, Carl Eugen Hoyos <ceffm...@gmail.com>: > 2019-01-26 18:53 GMT+01:00, Dilshod Mukhtarov <dilsh...@gmail.com>: >> HI, this is the patch that fixes HIDPI support in gdigrab > >> + double h_dpr; // Horizontal device pixel ratio >> + double v_dpr; // Vertical device pixel ratio > > I would expect these to be AVRational, if this is not > possible, it should be explained why.
Sorry if this was not an ideal comment, it should have been: All aspect ratio calculations (and all calculations related to aspect ratio) do not need double (or floats) but should be done as integer calculations. AVRational structs are often used, theoretically they may not be needed. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
