On Sat, Jan 19, 2019 at 09:12:41PM -0300, James Almer wrote:
> On 1/19/2019 7:54 PM, Michael Niedermayer wrote:
> > On Sat, Jan 19, 2019 at 04:11:07PM -0300, James Almer wrote:
> >> On 1/19/2019 4:08 PM, Michael Niedermayer wrote:
> >>> On Sat, Jan 19, 2019 at 03:53:55PM -0300, James Almer wrote:
> >>>> On 1/19/2019 3:50 PM, Michael Niedermayer wrote:
> >>>>> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> >>>>> ---
> >>>>> libavformat/hcom.c | 2 +-
> >>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/libavformat/hcom.c b/libavformat/hcom.c
> >>>>> index 35515cc5b2..6d3d726fa5 100644
> >>>>> --- a/libavformat/hcom.c
> >>>>> +++ b/libavformat/hcom.c
> >>>>> @@ -38,7 +38,7 @@ static int hcom_probe(AVProbeData *p)
> >>>>> static int hcom_read_header(AVFormatContext *s)
> >>>>> {
> >>>>> AVStream *st;
> >>>>> - unsigned data_size, rsrc_size, huffcount;
> >>>>> + av_unused unsigned data_size, rsrc_size, huffcount;
> >>>>> unsigned compresstype, divisor;
> >>>>> unsigned dict_entries;
> >>>>> int ret;
> >>>>
> >>>> No, they should be removed and the relevant avio_rb32() replaced with
> >>>> avio_skip() alongside a comment to document what those bytes represent.
> >>>
> >>> I thought there might be some future code or checks that will use these
> >>> but if thats not the case then sure i can remove them
> >>>
> >>> thx
> >>
> >> data_size could i guess be used to set stream duration,
> >
> > where can i find hcom samples ?
> > do you have some URLs ?
> > (for testing such use of the field)
>
> Paul should know since he wrote both the decoder and demuxer. Also Compn
> i think.ping, does someone have a sample for this ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
