On Tue, Feb 05, 2019 at 10:42:32AM -0800, Baptiste Coudurier wrote: > Hi Niki, > > > > On Feb 4, 2019, at 6:03 PM, Niki Bowe <nb...@google.com> wrote: > > > > Hi Baptiste. > > I agree. This patch does cause it to fail in mov_write_header in the given > > example, by propagating the errors returned from mov_write_ac3_tag. > > > > It is not always extradata related. > > Eg EAC3 parses the packets during muxing to build the dec3 atom. Perhaps > > this should be made extradata, but its not today. > > A definitely not extradata related example: mov_write_tmcd_tag can fail for > > fps reasons. > > Many atom writing functions can fail and return error codes, but today very > > little error checking exists. > > Ok, patch looks good to me.
will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The smallest minority on earth is the individual. Those who deny individual rights cannot claim to be defenders of minorities. - Ayn Rand
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
