2019-02-09 23:14 GMT+01:00, Marton Balint <c...@passwd.hu>: > > > On Sat, 9 Feb 2019, Carl Eugen Hoyos wrote: > > +#if CONFIG_ICONV > + if (len && *p < 0x20) { >> + const char *encodings[] = { >> + "ISO6937", "ISO-8859-5", "ISO-8859-6", "ISO-8859-7", >> "ISO-8859-8", >> + "ISO-8859-9", "ISO-8859-10", "ISO-8859-11", "", >> "ISO-8859-13", >> + "ISO-8859-14", "ISO-8859-15", "", "", "", "", >> + "", "ISO-10646", "KSC_5601", "GB2312", "ISO-10646", "UTF-8", >> "", >> + "", "", "", "", "", "", "", "", "" > > Instead of ISO-10646 you probably should use UCS-2BE, VLC > is also doing this and the specs refer to the basic multilingual > plane. ISO-10646 alone is UCS-4 which uses 4 byte encoding, > probably not what we want here.
(Not "BIG-5"?) > Otherwise LGTM, thanks. Changed and pushed. Thank you for the review, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel