On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng <maskray-at-google....@ffmpeg.org> wrote: > --- a/libavutil/mem.h > +++ b/libavutil/mem.h > > +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__)) > + #define DECLARE_HIDDEN __attribute__ ((visibility ("hidden"))) > +#else > + #define DECLARE_HIDDEN > +#endif
libavutil/mem.h is a public header so any defines added should have appropriate prefixes (yes, the existing defines violate this which is something that should be addressed, but that's a different issue). Alternatively maybe those macros should be moved to some internal header because I don't really see any value of having inline asm support macros public. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel