On 3/21/2019 6:06 AM, Nicolas George wrote:
> Carl Eugen Hoyos (12019-03-20):
>> + if (par->codec_id != AV_CODEC_ID_AAC && par->codec_id !=
>> AV_CODEC_ID_MP4ALS) {
>> + av_log(ctx, AV_LOG_ERROR, "Only AAC, LATM and ALS are supported\n");
>> + return AVERROR_INVALIDDATA;
>> + }
>
> I think EINVAL is more correct in this kind of case: EINVAL for invalid
> parameters from the application, INVALIDDATA for invalid data from the
> files. A quick grep shows it is not the only place this is done like
> that. I do not think it is urgent to fix it, just keep it in mind for
> later if you agree.
>
> Regards,
You're absolutely right, this is an EINVAL error.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
