> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Thursday, April 4, 2019 06:38 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, RFC 2/2] lavc/vaapi_decode: find exact > va_profile for HEVC_REXT > > On Wed, Apr 03, 2019 at 12:10:22PM +0800, Linjie Fu wrote: > > Use the profile constraint flags to determine the exact va_profile for > > HEVC_REXT. > > > > Directly cast PTLCommon to H265RawProfileTierLevel, and use > ff_h265_get_profile > > to get the exact profile. > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > --- > > [v2]: use constraint flags to determine the exact profile, expose the > > codec-specific stuff at the beginning. > > [RFC]: is it acceptable to cast PTLCommon to H265RawProfileTierLevel for > > convenience? The members in PTLCommon should be strictly matched in > > H265RawProfileTierLevel. > > > > libavcodec/vaapi_decode.c | 74 +++++++++++++++++++++++++++++++-- > ------ > > 1 file changed, 59 insertions(+), 15 deletions(-) > > breaks build: > > CC libavcodec/vaapi_decode.o > libavcodec/vaapi_decode.c: In function ‘vaapi_decode_find_exact_profile’: > libavcodec/vaapi_decode.c:421:16: error: ‘VAProfileHEVCMain422_10’ > undeclared (first use in this function) > return VAProfileHEVCMain422_10; > ^ > libavcodec/vaapi_decode.c:421:16: note: each undeclared identifier is > reported only once for each function it appears in > libavcodec/vaapi_decode.c:423:16: error: ‘VAProfileHEVCMain444’ > undeclared (first use in this function) > return VAProfileHEVCMain444; > ^ > libavcodec/vaapi_decode.c:425:16: error: ‘VAProfileHEVCMain444_10’ > undeclared (first use in this function) > return VAProfileHEVCMain444_10; > ^ > libavcodec/vaapi_decode.c: At top level: > libavcodec/vaapi_decode.c:409:18: warning: > ‘vaapi_decode_find_exact_profile’ defined but not used [-Wunused- > function] > static VAProfile vaapi_decode_find_exact_profile(AVCodecContext *avctx) > ^ > make: *** [libavcodec/vaapi_decode.o] Error 1 > make: Target `all' not remade because of errors. > Thanks, will move the VA version check into the vaapi_decode_find_exact_profile() to fix the compile issue and avoid function not used warning. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
