On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote:
2019-04-09 11:36 GMT+02:00, Shivam Goyal <shi...@iitk.ac.in>:
flv: Add XV (Xunlie Video) Support.
Updated patch for ticket #3720.
Above is an acceptable commit message, slightly
better would be:
"
lavf/flv: Add XV (Xunlie Video) Support.
Fixes ticket #3720.
"
I applied your patch with git am and what I get as commit
message is:
Updated patch for ticket #3720. flv: Add XV (Xunlei Video) support
This is not ok.
The following probably doesn't work for some very large files:
+ offset = ((avio_r8(ic) + rot & 0xff)<<24) |
+ ((avio_r8(ic) + rot & 0xff)<<16) |
+ ((avio_r8(ic) + rot & 0xff)<<8) |
+ ((avio_r8(ic) + rot & 0xff)) + 0x200000;
I suggested:
offset = ((avio_r8(ic) + rot & 0xff) << 24 |
(avio_r8(ic) + rot & 0xff) << 16) |
(avio_r8(ic) + rot & 0xff) << 8) |
(avio_r8(ic) + rot & 0xff)) + 0x200000;
The suggested notation is wrong, are you want to suggest ?
offset =((avio_r8(ic) +rot &0xff) <<24|
(avio_r8(ic) +rot &0xff) <<16|
(avio_r8(ic) +rot &0xff) <<8|
(avio_r8(ic) +rot &0xff)) +0x200000;
There are still "for(" that should be "for (", "if(" that should be "if ("
and "+ rot )" that should be "+ rot)" (or no parentheses).
The script tools/patcheck should find them, it will also tell you
to add a line to Changelog and bump libavformat minor version.
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
