On 4/23/19, Alexander Strasser <eclip...@gmx.net> wrote: > Hi Paul, > > just three small comments from me... > > On 2019-04-22 11:51 +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol <one...@gmail.com> >> --- >> doc/filters.texi | 6 +++ >> libavfilter/af_astats.c | 86 ++++++++++++++++++++++++++++++++++++++--- >> 2 files changed, 86 insertions(+), 6 deletions(-) > > I was a bit surprised when I first saw the number of lines it > takes to add this feature. OTOH this is not a problem of this > patch, because it is mostly caused by the structure of the > code that was in place before. > > Changing the structure doesn't seem worth it yet. If > there will be an addition that is applicable to all the > individual stats, it should IMHO be reconsidered.
What are you proposing to change? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
