Am Mo., 6. Mai 2019 um 05:41 Uhr schrieb Jun Li <junli1...@gmail.com>:
> +    uint8_t* sd = NULL;

Wouldn't it simplify the patch if this were a pointer to int32_t?
Or is there a aliasing violation that can't be avoided?

> +    if (entry) {
> +        orientation = atoi(entry->value);
> +        sd = av_stream_new_side_data(ist->st, AV_PKT_DATA_DISPLAYMATRIX,
> +                                                sizeof(int32_t) * 9);

Most of the time, sizeof(type) makes little sense, if you cannot use
sizeof(variable),
just put "4" there.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to