On 5/12/2019 3:12 AM, Peter Ross wrote: > --- > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog | 1 + > doc/general.texi | 2 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h | 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/vp3.c | 718 +++++++- > libavcodec/vp4data.h | 3784 +++++++++++++++++++++++++++++++++++++++ > 7 files changed, 4478 insertions(+), 36 deletions(-) > create mode 100644 libavcodec/vp4data.h
As Carl mentioned, this is missing a vp4_decoder_select line in configure to enable the vp3 decoder, like the theora one does. There's nothing telling the build system what objects are required for this new decoder otherwise. Did you make sure Theora samples are unaffected? Those afaik are much more common in the wild than vp3. Wikimedia is full of them. Also, if you have distributable vp4 samples at hand, you should make at least one fate decoding test. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
