May 23, 2019, 12:22 PM by pr...@xvid.org: > On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: > >> Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne <d...@lynne.ee>: >> > >> > May 21, 2019, 8:44 AM by pr...@xvid.org <mailto:pr...@xvid.org>: >> > >> > > --- >> > > >> > > what's changed: >> > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks >> > > * improved vp4_read_mb_value thanks to reminars suggestions >> > > * improved configure vp3_decoder_select >> > > >> > > >> > > Changelog | 1 + >> > > configure | 1 + >> > > doc/general.texi | 2 + >> > > libavcodec/Makefile | 1 + >> > > libavcodec/allcodecs.c | 1 + >> > > libavcodec/avcodec.h | 1 + >> > > libavcodec/codec_desc.c | 7 + >> > > libavcodec/vp3.c | 746 ++++++++++++++++++++++-- >> > > libavcodec/vp4data.h | 1186 +++++++++++++++++++++++++++++++++++++++ >> > > 9 files changed, 1911 insertions(+), 35 deletions(-) >> > > create mode 100644 libavcodec/vp4data.h >> > > >> > >> > Just remove CONFIG_VP4_DECODER and make it part of the vp3 decoder. >> >> Wasn't this explicitly requested in an earlier review? >> (And it is common within FFmpeg) >> > > i'll leave the ifdefs inplace. > > lynne has a point though, disabling vp4 only reduces the final ffmpeg binary > by 25 kilobytes. >
Do remove them then, its not that much, regardless of what was said in a previous review, even you think so. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
