On 09/05/2019 03:46, Fu, Linjie wrote: >> -----Original Message----- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Monday, May 6, 2019 23:21 >> To: FFmpeg development discussions and patches <ffmpeg- >> de...@ffmpeg.org> >> Subject: [FFmpeg-devel] [PATCH] vaapi_encode: Refactor encode misc >> parameter buffer creation >> >> This removes the use of the nonstandard combined structures, which >> generated some warnings with clang and will cause alignment problems >> with some parameter buffer types. >> --- >> On 27/03/2019 14:18, Carl Eugen Hoyos wrote: >>> Attached patch fixes many warnings when compiling vaapi with clang. >>> Also tested with clang-3.4. >>> ... >> >> How about this approach instead? I think something like it is going to be >> needed anyway because of alignment problems with parameter structures >> which aren't yet used. >> >> - Mark >> >> >> libavcodec/vaapi_encode.c | 71 ++++++++++++++++++++++++---------- >> libavcodec/vaapi_encode.h | 23 +++-------- >> libavcodec/vaapi_encode_h264.c | 8 ++-- >> 3 files changed, 60 insertions(+), 42 deletions(-) > > LGTM, for separating Misc parameter structure(they are separated in MSDK too) > This is more robust for the features with alignment issues.(ROI, trellis, max > frame size as far as I know)
Applied. Thanks! - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".