On 18.06.2019, at 14:55, Michael Niedermayer <mich...@niedermayer.cc> wrote:
> Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in type > 'int' > Fixes: > 15265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5088311799971840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/bink.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/bink.c b/libavcodec/bink.c > index 8392bbeeb0..d18c0ceae4 100644 > --- a/libavcodec/bink.c > +++ b/libavcodec/bink.c > @@ -702,15 +702,15 @@ static int read_dct_coeffs(BinkContext *c, > GetBitContext *gb, int32_t block[64], > return quant_idx; > } > > -static void unquantize_dct_coeffs(int32_t block[64], const int32_t quant[64], > +static void unquantize_dct_coeffs(int32_t block[64], const uint32_t > quant[64], > int coef_count, int coef_idx[64], > const uint8_t *scan) > { > int i; > - block[0] = (block[0] * quant[0]) >> 11; > + block[0] = (int)(block[0] * quant[0]) >> 11; Huh? How do you know the multiplication result will fit in an int? IIRC casting an out-of-range value to int is undefined behaviour, or does the tool fail to check that? I might miss something, but it looks to me like just replacing one undefined behaviour with another... _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
