On Mon, Jul 22, 2019 at 11:13:46PM +0200, Marton Balint wrote:
> 
> On Sun, 21 Jul 2019, lance.lmw...@gmail.com wrote:
> 
> >From: Limin Wang <lance.lmw...@gmail.com>
> >
> >This patch haven't make other pixel format usable yet to make sure the test
> >result is same with rgb32 format.
> >
> >Reviewed-by: Marton Balint <c...@passwd.hu>
> 
> You should only add this if you got an explicit LGTM for a patch.

OK, got it. thanks for the review, it's very helpful.

> 
> >Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> >---
> >libavfilter/f_select.c | 34 ++++++++++++++++++++++++++++++----
> >1 file changed, 30 insertions(+), 4 deletions(-)
> 
> Ok, I applied the series with some minor fixes and rewordings of
> your commit messages, as they were a bit difficult to understand
> sometimes.
OK, after the change, it looks better.

> 
> Thanks,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to