On Tue, Aug 13, 2019 at 4:49 PM James Almer <jamr...@gmail.com> wrote:
> I'm fairly sure this was discussed before, but invalid arguments > shouldn't crash an user's application. They even have their own > standardized errno value for this purpose. > asserts() are to catch bugs in our code, not in theirs. Returning a NULL > pointer is the preferred behavior. > Thank you for the feedback, I will update the patch accordingly. Also I noticed I was using FFMIN instead of FFMAX here: size_t size = sizeof(AVEncodeInfoFrame) + sizeof(AVEncodeInfoBlock)*FFMIN(nb_blocks - 1, 0); If anyone has any more feedback or wants to discuss the patch I'll also be available in the IRC channel. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
