Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin <tjop...@acc.umu.se >:
> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: > > Hi Tomas, > > > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se > > > : > > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt: > > > > Hi, > > > > > > > > attached patch fixes ticket #8077. > > > > Please comment. > > > > > > Probably OK, bitrates lower than 50000000 are fine in D-10 according to > > > S356m. > > > > > > > } else if ((sc->video_bit_rate >= 49999840) && (sc->video_bit_rate <= > > > > 50000000) && (mxf->time_base.den != 25)) { > > > > > > You could drop the extra parentheses, else it should be fine. > > > > > > > New patch attached. > > Looks OK. I'll push in a few days if no one else has any comments > Thanks. Would you mind porting it to branches 4.1 and 4.2? > > > The real fix is of course to add an explicit CBR mode to lavc, but > > > that's a bit more involved than this fix. > > > > IMX is being used less and less. Maybe it´s not worth the effort. > > It's not the only case where CBR MPEG-2 is desireable I think. > Certainly outside my concern however. Maybe something for x262? Since > x264 has such a mode I wouldn't be surprised if x262 does as well. > Yeah, a CBR option would definitely make it easier for users. So far I have not dealt with x262. Regards, Thomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".