On Thu, Aug 22, 2019 at 08:56:28 +0800, Guo, Yejun wrote:
> + /* This list must be iterated in reverse, so for the case that
> + * two regions overlapping, the more important area takes effect.
Nit: "overlap" or "are overlapping".
> +#ifdef VPX_CTRL_VP9E_SET_ROI_MAP
[...]
> +#endif
> +
> + av_assert0(!roi_supported);
> + if (!ctx->roi_warned) {
> + ctx->roi_warned = 1;
> + av_log(avctx, AV_LOG_WARNING, "ROI is not supported, please upgrade
> libvpx to version >= 1.8.1\n");
> + }
Nit: upgrading alone won't help, you'll actually need to rebuild. ;-)
(I'm saying it may be confusing to the end user, if they ever encounter
it.)
Cheers,
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
