Hi!
Attached patch fixes usage of uninitialized data reading broken r3d files.
Please review, Carl Eugen
From efce9940b890b9cf5a9e7400b05be10f6906fbb1 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffm...@gmail.com>
Date: Thu, 22 Aug 2019 12:02:36 +0200
Subject: [PATCH] lavf/r3d: Check avio_read() return value.
Fixes use of uninitialized data reading broken files.
Reported-by: Anatoly Trosinenko <anatoly dot trosinenko at gmail>
---
libavformat/r3d.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/r3d.c b/libavformat/r3d.c
index 224bcf780d..919c3c4960 100644
--- a/libavformat/r3d.c
+++ b/libavformat/r3d.c
@@ -98,7 +98,8 @@ static int r3d_read_red1(AVFormatContext *s)
r3d->audio_channels = avio_r8(s->pb); // audio channels
av_log(s, AV_LOG_TRACE, "audio channels %d\n", tmp);
- avio_read(s->pb, filename, 257);
+ if (avio_read(s->pb, filename, 257) < 0)
+ return AVERROR_INVALIDDATA;
filename[sizeof(filename)-1] = 0;
av_dict_set(&st->metadata, "filename", filename, 0);
--
2.22.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
