On 9/21/2019 10:07 AM, Moritz Barsnick wrote: > On Sat, Sep 21, 2019 at 19:29:47 +0800, Jun Zhao wrote: >> + else { >> + av_log(NULL, AV_LOG_ERROR, "Invalid chan_config %d\n", >> c->chan_config); >> + return -1; >> + } > > I know the function definition says it returns -1 on error, but that's > already not the case: It can return AVERROR_INVALIDDATA by means of the > call to parse_config_ALS(). I believe the doc should be changed, and > this code change should also return AVERROR_INVALIDDATA. > > Furthermore, can you pass and find a useful context for this av_log() > (and for the one in parse_config_ALS()? av_log() with NULL context is > very unfortunate.
avpriv_mpeg4audio_get_config() is tied to the ABI, so such changes can only happen after a major bump. It could be done to ff_mpeg4audio_get_config_gb() in the meantime, using a new logctx paramtere, and schedule the addition to avpriv_mpeg4audio_get_config() with a preprocessor check. I'll look into doing that in a bit. > > Cheers, > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".