On Mon, 23 Sep 2019, Limin Wang wrote:
On Sun, Sep 22, 2019 at 08:54:36PM +0200, Marton Balint wrote:
On Sat, 21 Sep 2019, lance.lmw...@gmail.com wrote:
>From: Limin Wang <lance.lmw...@gmail.com>
>
>Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
>---
>doc/filters.texi | 2 ++
>libavfilter/vf_framerate.c | 17 +++++++++++------
>2 files changed, 13 insertions(+), 6 deletions(-)
>
>diff --git a/doc/filters.texi b/doc/filters.texi
>index bbfdad4..fce4ef4 100644
>--- a/doc/filters.texi
>+++ b/doc/filters.texi
>@@ -10637,6 +10637,8 @@ Specify flags influencing the filter process.
>Available value for @var{flags} is:
>
>@table @option
>+@item none
>+Disable scene change detection
This is only true if no additional flags are added later. The reason
of using a flags option is future extensibility, so adding such a
constant kind of defeats that purpose. It is also uneeded, "none" is
a a named constant which you can always use to explicitly set no
flags.
So this patch seems uneeded.
Marton, thanks for your review, the none flags is for debug purpose,
without sceencut detection, the result will consistent. So it's
necessary to have none flags to turn it off.
You can change flags using the +flag or -flag syntax. You don't need a
separate constant for this.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
