On Sun, Sep 22, 2019 at 11:55:49AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang <lance.lmw...@gmail.com> > > The multithread is avoid one core cpu is full with other filter like scale > etc. > About the performance, the gain is very small, below is my testing for > performance. > In order to avoid the disk bottleneck, I'll use stream_loop mode for 10 frame > only. > > ./ffmpeg -y -i ~/Movies/4k_Rec709_ProResHQ.mov -c:v v210 -f rawvideo -frames > 10 > ~/Movies/1.v210 > > master: > ./ffmpeg -threads 1 -s 4096x3072 -stream_loop 100 -i ~/Movies/1.v210 > -benchmark > -f null - > frame= 1010 fps= 42 q=-0.0 Lsize=N/A time=00:00:40.40 bitrate=N/A speed=1.69x > video:529kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing > overhead: unknown > bench: utime=10.082s stime=13.784s rtime=23.889s > bench: maxrss=147836928kB > > patch applied: > ./ffmpeg -threads 4 -thread_type frame+slice -s 4096x3072 -stream_loop 100 -i > ~/Movies/1.v210 -benchmark -f null - > > frame= 1010 fps= 55 q=-0.0 Lsize=N/A time=00:00:40.40 bitrate=N/A speed=2.22x > video:529kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing > overhead: unknown > bench: utime=11.407s stime=17.258s rtime=18.279s > bench: maxrss=442884096kB > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > --- > libavcodec/v210dec.c | 131 > ++++++++++++++++++++++++++++++++------------------- > 1 file changed, 83 insertions(+), 48 deletions(-) > > diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c > index 6ce18aa..2e46342 100644 > --- a/libavcodec/v210dec.c > +++ b/libavcodec/v210dec.c > @@ -28,6 +28,7 @@ > #include "libavutil/internal.h" > #include "libavutil/mem.h" > #include "libavutil/intreadwrite.h" > +#include "thread.h" > > #define READ_PIXELS(a, b, c) \ > do { \ > @@ -37,6 +38,12 @@ > *c++ = (val >> 20) & 0x3FF; \ > } while (0) > > +typedef struct ThreadData { > + AVFrame *frame; > + uint8_t *buf; > + int stride; > +} ThreadData; > + > static void v210_planar_unpack_c(const uint32_t *src, uint16_t *y, uint16_t > *u, uint16_t *v, int width) > { > uint32_t val; > @@ -70,55 +77,28 @@ static av_cold int decode_init(AVCodecContext *avctx) > return 0; > } > > -static int decode_frame(AVCodecContext *avctx, void *data, int *got_frame, > - AVPacket *avpkt) > +static int v210_decode_slice(AVCodecContext *avctx, void *arg, int jobnr, > int threadnr) > { > V210DecContext *s = avctx->priv_data; > - > - int h, w, ret, stride, aligned_input; > - AVFrame *pic = data; > - const uint8_t *psrc = avpkt->data; > + int h, w; > + ThreadData *td = arg; > + AVFrame *frame = td->frame; > + int stride = td->stride;
> + int slice_h = avctx->height / avctx->thread_count; > + int slice_m = avctx->height % avctx->thread_count; > + int slice_start = jobnr * slice_h; > + int slice_end = slice_start + slice_h; assume avctx->height is 10 and avctx->thread_count is 11 slice_h becomes 0 and slice_start becomes 0 too for all threads [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".