On Wed, Nov 06, 2019 at 11:30:41AM +0100, Hendrik Leppkes wrote:
> On Wed, Nov 6, 2019 at 10:01 AM <lance.lmw...@gmail.com> wrote:
> >
> > From: Limin Wang <lance.lmw...@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> > ---
> > libavformat/utils.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 8196442dd1..8381498e2b 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -367,8 +367,7 @@ static int set_codec_from_probe_data(AVFormatContext
> > *s, AVStream *st,
> > fmt->name, score);
> > for (i = 0; fmt_id_type[i].name; i++) {
> > if (!strcmp(fmt->name, fmt_id_type[i].name)) {
> > - if (fmt_id_type[i].type != AVMEDIA_TYPE_AUDIO &&
> > - st->codecpar->sample_rate)
> > + if (st->codecpar->sample_rate)
> > continue;
> > if (st->request_probe > score &&
> > st->codecpar->codec_id != fmt_id_type[i].id)
>
> This change seems wrong, as you are practically rejecting probing of
> any audio now, since those would get a sample rate.
By the old logic, I assume sample_rate > 0 means the audio has been detected,
so don't probe the data again. The old code is for video only I think.
If have condition is broken, it should be add to fate testing.
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
