On 12/26/19, Paul B Mahol <one...@gmail.com> wrote:
> On 12/26/19, Nicolas George <geo...@nsup.org> wrote:
>> Paul B Mahol (12019-12-26):
>>> Signed-off-by: Paul B Mahol <one...@gmail.com>
>>> ---
>>> doc/filters.texi | 46 +++++
>>> libavfilter/Makefile | 1 +
>>> libavfilter/allfilters.c | 1 +
>>> libavfilter/vf_thistogram.c | 358 ++++++++++++++++++++++++++++++++++++
>>> 4 files changed, 406 insertions(+)
>>> create mode 100644 libavfilter/vf_thistogram.c
>>>
>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>> index 8c5d3a5760..4468351fc4 100644
>>> --- a/doc/filters.texi
>>> +++ b/doc/filters.texi
>>> @@ -11674,6 +11674,7 @@ the histogram. Possible values are @code{none},
>>> @code{weak} or
>>> @code{strong}. It defaults to @code{none}.
>>> @end table
>>>
>>> +@anchor{histogram}
>>> @section histogram
>>>
>>> Compute and draw a color distribution histogram for the input video.
>>> @@ -17717,6 +17718,51 @@ PAL output (25i):
>>> 16p: 33333334
>>> @end example
>>>
>>> +@section thistogram
>>> +
>>> +Compute and draw a color distribution histogram for the input video
>>> across time.
>>> +
>>> +Unlike @ref{histogram} video filter which only shows histogram of
>>> single
>>> input frame
>>> +at certain time, this filter shows also past histograms of number of
>>> frames defined
>>> +by @code{width} option.
>>
>> Is there a reason to make it a separate filter rather than adding the
>> option "width" to the existing filter?
>>
>> If it cannot be done, query_formats(), config_input() and a significant
>> part of filter_frame() are identical or almost identical: please reduce
>> code duplication.
>
> No, I will not.
>
> I hereby here summon FFmpeg Technical Committee to help me with this
> conflict.
Also there is bunch of all small different changes in code, which
conflict more with your proposal.
>
>>
>> Regards,
>>
>> --
>> Nicolas George
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
