This is a new version of my previous patchset reviewed by Tomas. http://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/247677.html
It takes into account the last feedback from Carl Eugen, I mean that the integration of s337m in wav is now similar to the existing one for spdif, main differences remains that : - s337m is not enabled by default (activated by the 'dolbyeprobe' AVOption) - container bit resolution is checked (DolbyE stream bit resolution = WAV PCM bit resolution) - takes data_end into account (see my latest patch here below: 'Fix s337m last packet parsing'), but this one could also be 'forwarded' to spdif - verbose detection and phase (I think it is a broadcast requirement) Fate samples can be found here: - 512.wav : http://0x0.st/zdW-.wav - 512.mxf.pcm : http://0x0.st/zdWo.pcm Thank you for this new review... Nicolas Gaullier (9): avformat/s337m: Use base AVClass for av_log usage avformat/s337m: Split read_packet/get_packet avformat/s337m: Consider container bit resolution avformat/s337m: New ff_s337m_probe() avformat/wavdec: s337m support avformat/wavdec: fix s337m/spdif probing beyond data_end avformat/wavdec: Fix s337m last packet parsing avformat/wavdec: Reindent after last commit avformat/wavdec: Test s337m libavformat/s337m.c | 87 +++++++++++++++++++++++++++++++++++++++++++--------- libavformat/s337m.h | 58 +++++++++++++++++++++++++++++++++++ libavformat/wavdec.c | 43 ++++++++++++++++++-------- tests/Makefile | 1 + tests/fate-run.sh | 4 +++ tests/fate/audio.mak | 5 +++ 6 files changed, 171 insertions(+), 27 deletions(-) create mode 100644 libavformat/s337m.h -- 2.14.1.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
