On Tue, 14 Jan 2020, Pedro Arthur wrote:

Hi,

Em qua., 8 de jan. de 2020 às 03:52, Guo, Yejun <yejun....@intel.com> escreveu:

Signed-off-by: Guo, Yejun <yejun....@intel.com>
---
 tests/fate/filter-video.mak                        |  4 ++
 ...filter-dnn_processing-halve_first_channel_float | 55 ++++++++++++++++++++++
 .../fate/filter-dnn_processing-halve_gray_float    | 55 ++++++++++++++++++++++
 3 files changed, 114 insertions(+)
 create mode 100644 
tests/ref/fate/filter-dnn_processing-halve_first_channel_float
 create mode 100644 tests/ref/fate/filter-dnn_processing-halve_gray_float

LGTM
Pushed, thanks.

The new float based test, fate-filter-dnn_processing-halve_first_channel_float, fails with lots of off-by-ones on ARM (both ARMv7 and AArch64). In general, float based tests need a reference file that allows off-by-one checks, but I'm not sure how well that works for video (as the reference needs to be uncompressed).

Can you think of other ways of making this test stable across platforms and architectures?

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to