On Mon, Feb 10, 2020 at 5:38 PM Anton Khirnov <an...@khirnov.net> wrote: > > Commit message summaries like "fix bug [$whatever external identifier] > are evil and should not be accepted IMO. They provide zero useful > information to someone reading the mailing list subjects or git > shortlog. > > The commit message summary should be understandable on its own, without > reading the whole commit message or looking up any external information. > In this case, 'fix a double free' would be appropriate. Any external > identifiers should be moved to the body of the message. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Shall keep in this mind next time. Did not think about it while sending the patch. -- ------------- Gautam _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
