On 15-02-2020 05:44 pm, Fu, Linjie wrote:
-----Original Message-----
From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
Nicolas George
Sent: Saturday, February 15, 2020 19:52
To: FFmpeg development discussions and patches <ffmpeg-
de...@ffmpeg.org>
Cc: Eoff, Ullysses A <ullysses.a.e...@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale
to disable/enable the default scale

Fu, Linjie (12020-02-15):
"automatically insert a scale filter at the end of the filter graph if a
resolution change is detected (enabled by default)."
in the help message and keep the current explanation unchanged in doc?
It's still twice as long as most help text. Take example on the other
help texts. Take example on the help text for autorotate!
It's based on some discussions previously talked in [1] to keep it sufficient 
and not confusing.

To keep it more precise, how about "automatically insert a scale filter at the end 
of the filter graph." ?

This is better. "if a resolution change is detected" isn't accurate anyway since filter *insertion* isn't conditional on frame change detection, which may happen 1000 frames into the stream.

Also, based on a glance at the patch, this doesn't apply to output streams exiting a complex filtergraph, right? Make a note of that.

Thanks,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to