On Mon, Mar 02, 2020 at 10:47:29AM +0530, Gyan Doshi wrote: > > > On 02-03-2020 10:05 am, Andreas Rheinhardt wrote: > >ff_alloc_extradata() already sets the size of the extradata so doing it > >again is unnecessary. > > > >Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com> > >--- > > libavformat/segment.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/libavformat/segment.c b/libavformat/segment.c > >index 5f7fe76600..d565183349 100644 > >--- a/libavformat/segment.c > >+++ b/libavformat/segment.c > >@@ -882,7 +882,6 @@ static int seg_write_packet(AVFormatContext *s, AVPacket > >*pkt) > > goto calc_times; > > } > > memcpy(st->codecpar->extradata, pkt_extradata, > > pkt_extradata_size); > >- st->codecpar->extradata_size = pkt_extradata_size; > > } > > } > > LGTM.
will apply thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
