Andreas Rheinhardt:
> Using ff_free_stream() makes the code more readable, more future-proof
> (the old code freed AVCodecContexts and AVCodecParameters and its
> substructures manually, so that there is a chance that there would be a
> memleak for some time if new substructures were added) and reduces
> code size.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com>
> ---
> libavformat/avidec.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
> diff --git a/libavformat/avidec.c b/libavformat/avidec.c
> index 00c3978b2d..ae343e732a 100644
> --- a/libavformat/avidec.c
> +++ b/libavformat/avidec.c
> @@ -600,21 +600,8 @@ static int avi_read_header(AVFormatContext *s)
> goto fail;
>
> ast = s->streams[0]->priv_data;
> - av_freep(&s->streams[0]->codecpar->extradata);
> - av_freep(&s->streams[0]->codecpar);
> -#if FF_API_LAVF_AVCTX
> -FF_DISABLE_DEPRECATION_WARNINGS
> - av_freep(&s->streams[0]->codec);
> -FF_ENABLE_DEPRECATION_WARNINGS
> -#endif
> - if (s->streams[0]->info)
> - av_freep(&s->streams[0]->info->duration_error);
> - av_freep(&s->streams[0]->info);
> - if (s->streams[0]->internal)
> - av_freep(&s->streams[0]->internal->avctx);
> - av_freep(&s->streams[0]->internal);
> - av_freep(&s->streams[0]);
> - s->nb_streams = 0;
> + st->priv_data = NULL;
> + ff_free_stream(s, st);
> if (CONFIG_DV_DEMUXER) {
> avi->dv_demux = avpriv_dv_init_demux(s);
> if (!avi->dv_demux)
>
Any comments on this patchset? If there are no objections, I'll apply it
tomorrow.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
