On Sat, Apr 04, 2020 at 11:42:06AM +0200, Nicolas George wrote: > Limin Wang (12020-04-04): > > I think it's caused by the keyframe flags, so have no clue how to check > > the beneficial for these fate testing. > > Take the actual files produced by the tests, possibly changing the > output format from framecrc to an actual format, and compare carefully > the version before the patch and the version after the patch.
the md5 framecrc is generated by libavformat/tests/movenc.c, I have no clue how the movenc testing work and how to get the real input to check why the frame isn't bitexact as I haven't see any subtitle track. > > Tests are there for a reason. If you cannot explain exactly why a change > in a reference file is beneficial, then the patch is not acceptable. > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
