Zane van Iperen: > On Sun, 29 Mar 2020 17:18:08 +0000 > "Zane van Iperen" <z...@zanevaniperen.com> wrote: > >> Adds support for the soundbank files used by the Pro Pinball series >> of games. >> >> Please CC for review. >> >> v6: >> - fix tools/probetest failure >> >> v5: >> - add probe function >> - add flag #define's >> >> v4: >> - fix adpcm index table type >> >> v3: >> - fix potential memory leak if read_header() fails >> - fix a buffer overread >> - attempt seek before updating state >> - remove unneeded check >> - naming fixes >> >> v2: >> - Add sanity checks in header fields >> - Formatting and comment fixes >> - Change the struct names to match the files >> >> Zane van Iperen (2): >> avcodec: add support for Cunning Developments' ADPCM >> avformat: add demuxer for Pro Pinball Series' Soundbanks >> >> Changelog | 2 + >> doc/general.texi | 1 + >> libavcodec/Makefile | 1 + >> libavcodec/adpcm.c | 33 +++++ >> libavcodec/adpcm_data.c | 13 ++ >> libavcodec/adpcm_data.h | 2 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h | 1 + >> libavcodec/codec_desc.c | 7 ++ >> libavcodec/version.h | 4 +- >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 1 + >> libavformat/pp_bnk.c | 263 >> +++++++++++++++++++++++++++++++++++++++ libavformat/version.h | >> 2 +- 14 files changed, 329 insertions(+), 3 deletions(-) >> create mode 100644 libavformat/pp_bnk.c >> >> -- >> 2.17.1 >> > > Hi all, > > Could I please have some reviews on this? > > If everything's good I have FATE tests and samples ready, which I will > send upon merge. > > I have a few minor changes but they're just slight comment changes, > which aren't worth sending as a v7. I can send them as a separate patch > afterwards. > This is not good as this separate patch would essentially just be avoidable noise. So please send an updated version.
- Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
