Michael Niedermayer <[EMAIL PROTECTED]> added the comment: Hi
On Fri, Oct 19, 2007 at 12:59:45AM -0000, Mans Rullgard wrote: > > Mans Rullgard <[EMAIL PROTECTED]> added the comment: > > That file is a PES stream, and every fifth packet has PES_extension_flag > incorrectly set to 1, causing the demuxer to overread the PES header. > Prior to r7853 the demuxer never read further than the DTS, so this > error had no impact. > > I'm attaching the simplest possible patch that makes the file play > again, not suggesting it should be applied as-is. > > Michael, in r7562 you made some changes to the bounds checking in the > header parsing. Care to comment? r7562 was just intended as simplification it wasnt intended to change actual behavior. and i think it also does not change actual behavior for valid streams (and for invalid streams behavor change requires a large number of things to be true ...) the idea behind r7562 was that checking after every read byte complicates the code alot and simply checking at the end would achive the same, that is (in the current code at least) seek back to after the last start code and search for the next start code is there a problem with r7562 ? as far is i understand this bug is caused by the r7853 code causing a correct detection of an invalidly set flag and then trying to resync from the last startcode, while e7852 did ignore the invalid flag [...] ______________________________________________________ FFmpeg issue tracker <[EMAIL PROTECTED]> <https://roundup.mplayerhq.hu/roundup/ffmpeg/issue198> ______________________________________________________
