Michael Niedermayer <[EMAIL PROTECTED]> added the comment:

On Tue, Jul 15, 2008 at 09:15:45PM +0000, Carl Eugen Hoyos wrote:
> 
> Carl Eugen Hoyos <[EMAIL PROTECTED]> added the comment:
> 
> Michael?
> (I did not try to analyze why there is a call to av_dup_packet)

The call to av_dup_packet() looks correct and needed to me.
(think of subsequent avpackets using the same static buffer)

ffplay is multithreaded and uses queues of AVPackets ...

The problem is likely in av_dup_packet() and how it deals with the mmap
buffers

Either it should treat them like malloc() buffers in which case then
they also must behave that way and MUST work fine if there are 50 of them
around at the same time and get randomly freed from several threads ...

Otherwise dup_packet must malloc() and memcpy() (which is of course
not very good speedwise)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein

______________________________________________________
FFmpeg issue tracker <[EMAIL PROTECTED]>
<https://roundup.mplayerhq.hu/roundup/ffmpeg/issue507>
______________________________________________________

Reply via email to