Michael Niedermayer <[EMAIL PROTECTED]> added the comment:
On Wed, Oct 01, 2008 at 03:50:17PM +0000, Vitor wrote:
>
> Vitor <[EMAIL PROTECTED]> added the comment:
>
> Hi
>
> Baptiste Coudurier wrote:
> > Hi Vitor,
> >
> > Vitor wrote:
> >> Vitor <[EMAIL PROTECTED]> added the comment:
> >>
> >> Following patch fixes it.
> >>
> >> Index: libavformat/rmdec.c
> >> ===================================================================
> >> --- libavformat/rmdec.c (revision 15428)
> >> +++ libavformat/rmdec.c (working copy)
> >> @@ -118,6 +118,7 @@
> >> } else if (!strcmp(buf, "28_8")) {
> >> st->codec->codec_id = CODEC_ID_RA_288;
> >> st->codec->extradata_size= 0;
> >> + st->codec->sample_fmt = SAMPLE_FMT_FLT;
> >> rm->audio_framesize = st->codec->block_align;
> >> st->codec->block_align = coded_framesize;
> >>
> >
> > I think this is only because audio frame is not decoded before
> > dump_format which print infos.
>
> Yes, but there is no plan to change that, is there?
>
> > This will be fixed when default sample_fmt is set to SAMPLE_FMT_NONE.
>
> Unless I'm missing something them it'll just print
>
> Stream #0.0: Audio: real_288, 8000 Hz, mono
>
> which is not as good as
>
> Stream #0.0: Audio: real_288, 8000 Hz, mono, flt
>
> So my patch is useful anyway...
The patch is not correct, the demuxer does not know what the decoder
will output. After all it didnt return floats in the past and that was
with no changes in libavformat.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
______________________________________________________
FFmpeg issue tracker <[EMAIL PROTECTED]>
<https://roundup.mplayerhq.hu/roundup/ffmpeg/issue641>
______________________________________________________
