Michael Niedermayer <[email protected]> added the comment: On Wed, Jul 01, 2009 at 05:15:30AM +0000, Alexander Strange wrote: > > Alexander Strange <[email protected]> added the comment: > > Of course, but it was late and I was hoping someone else would figure it > out while I was asleep ;) > > Like issue1229 and issue1238, this is caused by trash being read as various > NALs. It sees NAL_DPA and then NAL_DPC, which causes it to start decoding. > This is because NAL_DPA always sets data_partitioning (which is what DPC > checks for, and is not used anywhere else) even if there was an error > decoding it. > > Attached patch fixes issue1228, issue1229, issue1238 (without -debug 1). > > ---------- > nosy: +astrange > > _____________________________________________________ > FFmpeg issue tracker <[email protected]> > <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1228> > _____________________________________________________ > h264.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > e0a550b8cd1b93b920afac1e7f44409249eb2f78 issue1228-3.diff > Index: libavcodec/h264.c > =================================================================== > --- libavcodec/h264.c (revision 19309) > +++ libavcodec/h264.c (working copy) > @@ -7603,9 +7603,12 @@ > init_get_bits(&hx->s.gb, ptr, bit_length); > hx->intra_gb_ptr= > hx->inter_gb_ptr= NULL; > + > + if (err = decode_slice_header(hx, h)) > + break; > + > hx->s.data_partitioning = 1; > > - err = decode_slice_header(hx, h); > break;
errors are <0 in ffmpeg, always besides this, its ok, feel free to commit with that fix [...] _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1228> _____________________________________________________
