Michael Niedermayer <[email protected]> added the comment: On Thu, Jul 16, 2009 at 08:52:03PM +0000, Jeff Downs wrote: > > Jeff Downs <[email protected]> added the comment: > > ffmpeg.c allocates audio resampling and output temporary buffers using > seemingly > arbitrary multiples of MAX_AUDIO_PACKET_SIZE (maybe they were right at some > point but they are insufficient now).
if it worked in the past, id like to know what broke it > This is overflowing at least the buffer used for resampling the audio (bug is > tripping on resample from 5khz -> 44.1khz, 8 bit to 16 bit). > > The attached changes the audio output code to size the buffers according to > actual need. It also removes one extraneous output buffer that was allocated > for > the case of (only) sample format conversion. > > ---------- > substatus: reproduced -> analyzed > > _____________________________________________________ > FFmpeg issue tracker <[email protected]> > <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1167> > _____________________________________________________ > ffmpeg.c | 93 > +++++++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 61 insertions(+), 32 deletions(-) > 60efb540b9b0e62d2557a7d1678baa96d0b21ba6 1167-size_audio_bufs.diff this patch is a mess, moving code around anddoing other changes ... [...] _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1167> _____________________________________________________
