Michael Niedermayer <[email protected]> added the comment: On Wed, Jul 29, 2009 at 09:25:56PM +0000, Jeff Downs wrote: > > Jeff Downs <[email protected]> added the comment: > > File is corrupted such that an mb_y (slice number) equal to the mb_height is > encountered. > The computation and comparison that is allocating thread contexts to roughly > equal fractions of the image to decode depends on mb_y being strictly less > than > mb_height. > With mb_y >= mb_height, the check deciding to allocate a thread or not will be > true even after all threads are already allocated. > > Attached fixes by giving out thread contexts only when mb_y is valid. > When the invalid slice is at the middle or end of a coded picture, it won't > matter at all -- the last thread assigned will just encounter the bad slice, > catch the bad y address, and error the slice. For invalid slices at the > start, > they will be skipped.
there are so any mb_y checks, why dont you fix one of them instead of adding yet another. slice_decode_thread contains a check it can be moved up decode_chunks contains one limited to mpeg2 ... [...] _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1277> _____________________________________________________
