Reimar Döffinger <[email protected]> added the comment:
On Tue, Aug 25, 2009 at 03:27:11PM +0000, Kent Mein wrote:
> Index: libavformat/rdt.c
> ===================================================================
> --- libavformat/rdt.c (revision 19694)
> +++ libavformat/rdt.c (working copy)
> @@ -200,6 +200,9 @@
> len_included, need_reliable;
> uint32_t timestamp;
>
> + if (!buf)
> + return -1;
> +
That certainly is the wrong point to fix.
I have no clue what the condition
if (!buf && s->prev_stream_id != -1) {
in ff_rdt_parse_packet is supposed to mean,
on that depends what/where the right solution would be.
> Index: libavformat/r3d.c
> ===================================================================
> --- libavformat/r3d.c (revision 19694)
> +++ libavformat/r3d.c (working copy)
> @@ -87,6 +87,7 @@
> dprintf(s, "audio channels %d\n", tmp);
> if (tmp > 0) {
> AVStream *ast = av_new_stream(s, 1);
> + if (!ast) return -1;
> ast->codec->codec_type = CODEC_TYPE_AUDIO;
> ast->codec->codec_id = CODEC_ID_PCM_S32BE;
> ast->codec->channels = tmp;
Messed-up indentation, also I think we usually return AVERROR(ENOMEM)
_____________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/roundup/ffmpeg/issue1339>
_____________________________________________________
