Reimar Döffinger <[email protected]> added the comment:

On Tue, Aug 25, 2009 at 09:26:22PM +0000, verem wrote:
> verem <[email protected]> added the comment:
> May be i am wrong, but actually added condition (avi->stream_index < 0) 
> prevents
> from broking ast->remaining value:
>     - ast->remaining been initialized in /index honour/ code then
> (avi->stream_index < 0)
>     - ast->remaining been decremented in packet splitting code then
> (avi->stream_index >= 0)
> 
> Actually ast->remaining initialized either in /index honour/ code or in a 
> resync
> part after reading appropriate avi chunk.
> 
> So i do not see a situation for breaking packet splitting code.

The point of splitting AFAICT is so that they can be properly
interleaved. With your change, this will no longer be possible, all
split audio packets will be produced before the next video frame is
inserted, instead of the video frame being demuxed whenever it is most
appropriate.

> PS:
> I did a patch with a lot of av_log to find the problem and there is some 
> logging
> output (i selected some continuous av_read_packet calls):

With or without your patch? I suspect with, it would be interesting to
see what it looks like without, it's unclear to me what exactly causes
the issue (IMO your patch only "fixes" it as a side-effect because it
disable some of the code's logic).

_____________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/roundup/ffmpeg/issue1343>
_____________________________________________________

Reply via email to