Reimar Döffinger <[email protected]> added the comment: On Sat, Oct 10, 2009 at 06:40:36PM +0000, Justin Ruggles wrote: > > And what is the purpose of the pos < ctx->data_offset check anyway? > > It was to handle the case when the file is seeked to before the start of > data. But if AVFormatContext->data_offset is used as you suggested, > this should be handled in pcm_read_seek().
If you do not set data_offset, it is already automatically set to the "current" position after read_headers, so check there you really need to do anything at all. > > Also I wonder if/how well this works with multiple SSND chunks and > > seeking (probably not that important, but a nice-to-have). > > Right now it doesn't work for demuxing, much less seeking, with multiple > SSND chunks. The patch does not change that. But yes, it should be > fixed to handle it properly. Now if I only had a sample... It might not be allowed. If not even demuxing works currently, just ignore this possibility for now I'd say. _____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue1455> _____________________________________________________
